Bug #1111

On/Off when users can only see their own threads.

Added by Tim B. almost 4 years ago. Updated over 2 years ago.

Status:ClosedStart date:07/28/2010
Priority:NormalDue date:
Assignee:Tom Moore% Done:

100%

Category:Forum Display
Target version:1.6.7
Reproducibility:Often Database Type:
Reported In MyBB Version:1.6.0 Database Version:
PHP Version: SQA assignments:Nathan Malcolm
Browser:

Description

It seems the On/Off icon doesn't update for users who have only have permission to see their own threads in a forum.

History

#1 Updated by Diogo Parrinha almost 4 years ago

I can confirm that from the Private Enquiries forum at MyBB.

#2 Updated by Tom Moore almost 4 years ago

We have a slight problem here.

The lightbulbs tell you if there's a new post in a forum - however, the lastpost data in the forum doesn't carry who originally created the thread. I can easily make the lightbulb appear if there is a new post in a forum, but it won't be able to tell whether it's your thread that's got the new post, or someone elses.

So the only answer to this is to create a really scrappy workaround that checks the owner of the lastpost thread, and if that owner is the current user, then display the lightbulb.

--
Ryan - the only method I can think of at the moment is to loop through the forum cache before the main loop, collecting the lastpost's tid - then querying these tids and creating an array of 'created threads from lastpost info' (which we can then check for in the main loop). Would you be happy for me to try this? Seems a lot of work for a lightbulb to me...

#3 Updated by Ryan Gordon almost 4 years ago

Let's have a triage meeting on this one and talk about development solutions in depth for 2.0 and possible short term solutions for 1.6.

There's really some long standing issues on the tracking system that we should fix.

#4 Updated by Michael Malin almost 4 years ago

  • Status changed from New to Confirmed

This bug exists. It isn't important for me whether it will me fixed in the 1.6 series or in the 2.0 series.

#5 Updated by Tom Moore over 2 years ago

  • Category set to Forum Display
  • Status changed from Confirmed to Assigned
  • Assignee set to Tom Moore
  • Target version set to 1.6.6

#6 Updated by Tom Moore over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r5698.

#7 Updated by Nathan Malcolm over 2 years ago

  • Status changed from Resolved to Feedback
  • SQA assignments set to Nathan Malcolm

I think you have forgotten to global $db under build_forumbits()

PHP Fatal error:  Call to a member function simple_select() on a non-object in /var/www/html/mybb-svn/inc/functions_forumlist.php on line 88

#8 Updated by Tom Moore over 2 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r5711.

Ahahaha.

#9 Updated by Nathan Malcolm over 2 years ago

  • Status changed from Resolved to Closed

#10 Updated by Tom Moore over 2 years ago

  • Target version changed from 1.6.6 to 1.6.7

Also available in: Atom PDF