Bug #722

Group Join Requests From Guests

Added by Jesse Labrocca about 4 years ago. Updated almost 4 years ago.

Status:ClosedStart date:02/01/2010
Priority:NormalDue date:
Assignee:Tom Moore% Done:

100%

Category:Admin Control Panel
Target version:1.4.12
Reproducibility:Always Database Type:
Reported In MyBB Version:1.4.11 Database Version:
PHP Version: SQA assignments:
Browser:

Description

I have group join requests from "guests" and they won't delete/decline. My guess is that it's because the name variable is empty in the forum name="request[]". I also believe the guest declines are because of member merges as I commit this action often and almost never delete accounts.

So either one of two things should be changed.

1. Make sure merge takes into account the join requests.
2. Don't allow guests on the moderate join request form.

History

#1 Updated by Tom Moore about 4 years ago

  • Category set to Admin Control Panel
  • Status changed from New to Assigned
  • Assignee set to Tom Moore
  • Target version set to 1.4.12

#2 Updated by Tom Moore about 4 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4765.

Only the first applies; guests can't access the UserCP to get to the join requests.

#3 Updated by Jesse Labrocca about 4 years ago

Tom the first applies to group leaders that moderate join requests. I was saying that the query should discount the "guests" and not even place them on the form. This would also correct existing empty join requests. Hope you get what I mean.

In usercp.php

@ $query = $db->simple_select("joinrequests", "*", "uid='".$mybb->user['uid']."' AND gid='".intval($mybb->input['joingroup'])."'");
$joinrequest = $db->fetch_array($query);
if($joinrequest['rid']) {
error($lang->already_sent_join_request);
}
if($mybb->input['do'] "joingroup" && $usergroup['type'] 4) {
@

Maybe an exempt if uid=0 or empty in there somewhere? Then on form guests won't show.

#4 Updated by Ryan Gordon about 4 years ago

  • Status changed from Resolved to Feedback

#5 Updated by Tom Moore about 4 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4856.

#6 Updated by Stefan T. almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF